On Mon, 3 Jun 2019 at 07:41, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> Most generic crypto algorithms declare a driver name ending in
> "-generic". The rest don't declare a driver name and instead rely on
> the crypto API automagically appending "-generic" upon registration.
>
> Having multiple conventions is unnecessarily confusing and makes it
> harder to grep for all generic algorithms in the kernel source tree.
> But also, allowing NULL driver names is problematic because sometimes
> people fail to set it, e.g. the case fixed by commit 417980364300
> ("crypto: cavium/zip - fix collision with generic cra_driver_name").
>
> Of course, people can also incorrectly name their drivers "-generic".
> But that's much easier to notice / grep for.
>
> Therefore, let's make cra_driver_name mandatory. Patch 1 gives all
> generic algorithms an explicit cra_driver_name, and Patch 2 makes
> cra_driver_name required for algorithm registration.
>
> Eric Biggers (2):
> crypto: make all generic algorithms set cra_driver_name
> crypto: algapi - require cra_name and cra_driver_name
>
Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
