Re: [PATCH] crypto: testmgr - add some more preemption points

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 3 Jun 2019 at 07:42, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> Call cond_resched() after each fuzz test iteration.  This avoids stall
> warnings if fuzz_iterations is set very high for testing purposes.
>
> While we're at it, also call cond_resched() after finishing testing each
> test vector.
>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Acked-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>

> ---
>  crypto/testmgr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index 2ba0c487ea281..f7fdd7fe89a9e 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -1496,6 +1496,7 @@ static int test_hash_vec(const char *driver, const struct hash_testvec *vec,
>                                                 req, desc, tsgl, hashstate);
>                         if (err)
>                                 return err;
> +                       cond_resched();
>                 }
>         }
>  #endif
> @@ -1764,6 +1765,7 @@ static int __alg_test_hash(const struct hash_testvec *vecs,
>                                     hashstate);
>                 if (err)
>                         goto out;
> +               cond_resched();
>         }
>         err = test_hash_vs_generic_impl(driver, generic_driver, maxkeysize, req,
>                                         desc, tsgl, hashstate);
> @@ -2028,6 +2030,7 @@ static int test_aead_vec(const char *driver, int enc,
>                                                 &cfg, req, tsgls);
>                         if (err)
>                                 return err;
> +                       cond_resched();
>                 }
>         }
>  #endif
> @@ -2267,6 +2270,7 @@ static int test_aead(const char *driver, int enc,
>                                     tsgls);
>                 if (err)
>                         return err;
> +               cond_resched();
>         }
>         return 0;
>  }
> @@ -2609,6 +2613,7 @@ static int test_skcipher_vec(const char *driver, int enc,
>                                                     &cfg, req, tsgls);
>                         if (err)
>                                 return err;
> +                       cond_resched();
>                 }
>         }
>  #endif
> @@ -2808,6 +2813,7 @@ static int test_skcipher(const char *driver, int enc,
>                                         tsgls);
>                 if (err)
>                         return err;
> +               cond_resched();
>         }
>         return 0;
>  }
> --
> 2.21.0
>



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux