Most generic crypto algorithms declare a driver name ending in
"-generic". The rest don't declare a driver name and instead rely on
the crypto API automagically appending "-generic" upon registration.
Having multiple conventions is unnecessarily confusing and makes it
harder to grep for all generic algorithms in the kernel source tree.
But also, allowing NULL driver names is problematic because sometimes
people fail to set it, e.g. the case fixed by commit 417980364300
("crypto: cavium/zip - fix collision with generic cra_driver_name").
Of course, people can also incorrectly name their drivers "-generic".
But that's much easier to notice / grep for.
Therefore, let's make cra_driver_name mandatory. Patch 1 gives all
generic algorithms an explicit cra_driver_name, and Patch 2 makes
cra_driver_name required for algorithm registration.
Eric Biggers (2):
crypto: make all generic algorithms set cra_driver_name
crypto: algapi - require cra_name and cra_driver_name
crypto/algapi.c | 22 ++++------------------
crypto/anubis.c | 1 +
crypto/arc4.c | 2 ++
crypto/crypto_null.c | 3 +++
crypto/deflate.c | 1 +
crypto/fcrypt.c | 1 +
crypto/khazad.c | 1 +
crypto/lz4.c | 1 +
crypto/lz4hc.c | 1 +
crypto/lzo-rle.c | 1 +
crypto/lzo.c | 1 +
crypto/md4.c | 7 ++++---
crypto/md5.c | 7 ++++---
crypto/michael_mic.c | 1 +
crypto/rmd128.c | 1 +
crypto/rmd160.c | 1 +
crypto/rmd256.c | 1 +
crypto/rmd320.c | 1 +
crypto/serpent_generic.c | 1 +
crypto/tea.c | 3 +++
crypto/tgr192.c | 21 ++++++++++++---------
crypto/wp512.c | 21 ++++++++++++---------
crypto/zstd.c | 1 +
23 files changed, 59 insertions(+), 42 deletions(-)
--
2.21.0
