On 06.01.2022 11:40:52, Dario Binacchi wrote:
> > I was hoping that we can find a better string that better represents
> > what this option does.
> >
> > > Do you think it makes sense to explicitly RTR ("rtr-notify") instead
> > > of RxFIFO (rx-fifo)? And if it makes sense to make it clear that it
> > > occurs at the expense of a smaller number of messages allocated for
> > > reception?
> >
> > I see it the other way round, probably biased by the existing driver :)
>
> Could this change of perspective then not require the addition of a new
> quirk that allows to change between rx-fifo and rx-mailbox mode?
ACK - I only want to enable switching between rx-fifo and rx-mailbox
mode for the devices that currently use rx-fifo mode. It makes no sense
to switch from rx-mailbox to rx-fifo mode if your flexcan IP core can
receive RTR messages in rx-mailbox mode.
There even is the limitation that rx-fifo mode doesn't support CAN-FD
mode....but the driver checks for this.
> > The user wants to use more buffers at the expense of loosing the ability
> > to receive RTR messages.
>
> Can / should it be documented in some way other than the commit message?
Yes - Documentation/networking/device_drivers/can/ looks like a good place.
> > I've talked to one of my colleges and we came to the conclusion that the
> > driver should present the user the option to opt out from RTR reception.
> >
> > If the user has opted out from RTR reception the driver can do internal
> > optimization, such as switching from FIFO to mailbox mode.
>
> Is it really always true? In the case of imx6 can we still remain in
> mailbox mode
> and enable / disable RTR reception through Remote Request Storing (CTRL2
> [RRS]) bit?
>
> > What about "rtr-rx" or "rx-rtr"?
>
> I prefer "rx-rtr"
Ok, I'll change the patch. Can you write send a doc RFC patch. Place it
in the path mentioned above, please use rst format.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: PGP signature
