Hi Marc,
resend in plain text
On Tue, Jan 4, 2022 at 4:42 PM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> Hello,
>
> this picks up Dario's work.
>
> Changes since RFC:
> - move driver into subdir
> - rename flexcan_main.c -> flexcan-core.c
> (mcp251xfd and tcan4x5x driver have the same naming scheme)
> - use copyright notice from flexcan.c in flexcan.h
> - add private flag support to set rx-fifo
> - remove drvinfo, the kernel will fall back to the default implementation
>
> Show available private flags:
>
> | $ sudo ethtool --show-priv-flags can0
> | Private flags for can0:
> | rx-fifo: on
>
> Change private flag:
>
> | $ sudo ethtool --set-priv-flags can0 rx-fifo off
> | netlink error: Device or resource busy
>
> ...does not work if interface is up.
>
> Shut down interface and change "rx-fifo":
>
> | $ sudo ip link set dev can0 down
> | $ sudo ethtool --set-priv-flags can0 rx-fifo off
> | $ sudo ethtool --show-priv-flags can0
> | Private flags for can0:
> | rx-fifo: off
> |
> | $ sudo ip link set dev can0 up
> | $ sudo ethtool --show-priv-flags can0
> | Private flags for can0:
> | rx-fifo: off
>
> Is the name "rx-fifo" acceptable? Can you think of a better name?
If I am not mistaken this series arises from the need to deactivate
the RxFIFO only if it is
acceptable not to receive the notification of RTR messages. I wonder
if this can be made
explicit to the user.
Do you think it makes sense to explicitly RTR ("rtr-notify") instead
of RxFIFO (rx-fifo) ?
And if it makes sense to make it clear that it occurs at the expense
of a smaller number
of messages allocated for reception?
>
> What about adding a new quirk to the driver, only if that quirk is
> that, it is allowed to change between rx-fifo and rx-mailbox mode?
>
What platforms are you thinking of for this type of quirk to add?
regards,
Dario
>
> What to you think?
>
> regards,
> Marc
>
>
>
>
--
Dario Binacchi
Embedded Linux Developer
dario.binacchi@xxxxxxxxxxxxxxxxxxxx
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@xxxxxxxxxxxxxxxxxxxx
www.amarulasolutions.com
