Re: [PATCH v2 1/3] can: flexcan: change RX-FIFO feature at runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05.01.2022 09:25:35, Dario Binacchi wrote:
> > Is the name "rx-fifo" acceptable? Can you think of a better name?
> 
> If I am not mistaken this series arises from the need to deactivate
> the RxFIFO only if it is acceptable not to receive the notification of
> RTR messages. I wonder if this can be made explicit to the user.
> 
> Do you think it makes sense to explicitly RTR ("rtr-notify") instead
> of RxFIFO (rx-fifo) ?
> 
> And if it makes sense to make it clear that it occurs at the expense
> of a smaller number of messages allocated for reception?
> 
> >
> > What about adding a new quirk to the driver, only if that quirk is
> > that, it is allowed to change between rx-fifo and rx-mailbox mode?
> >
> 
> What platforms are you thinking of for this type of quirk to add?

Add this quirk for all platforms that currently don't use
FLEXCAN_QUIRK_USE_OFF_TIMESTAMP.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux