Hi Marc,
On Wed, Jan 5, 2022 at 11:14 AM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
>
> On 05.01.2022 09:25:35, Dario Binacchi wrote:
> > > Is the name "rx-fifo" acceptable? Can you think of a better name?
> >
> > If I am not mistaken this series arises from the need to deactivate
> > the RxFIFO only if it is acceptable not to receive the notification of
> > RTR messages.
>
> ACK
>
> > I wonder if this can be made explicit to the user.
>
> I was hoping that we can find a better string that better represents
> what this option does.
>
> > Do you think it makes sense to explicitly RTR ("rtr-notify") instead
> > of RxFIFO (rx-fifo)? And if it makes sense to make it clear that it
> > occurs at the expense of a smaller number of messages allocated for
> > reception?
>
> I see it the other way round, probably biased by the existing driver :)
Could this change of perspective then not require the addition of a new
quirk that allows to change between rx-fifo and rx-mailbox mode?
> The user wants to use more buffers at the expense of loosing the ability
> to receive RTR messages.
Can / should it be documented in some way other than the commit message?
>
> I've talked to one of my colleges and we came to the conclusion that the
> driver should present the user the option to opt out from RTR reception.
>
> If the user has opted out from RTR reception the driver can do internal
> optimization, such as switching from FIFO to mailbox mode.
Is it really always true? In the case of imx6 can we still remain in
mailbox mode
and enable / disable RTR reception through Remote Request Storing (CTRL2
[RRS]) bit?
>
> What about "rtr-rx" or "rx-rtr"?
I prefer "rx-rtr"
Thanks and regards,
Dario
>
> regards,
> Marc
>
> --
> Pengutronix e.K. | Marc Kleine-Budde |
> Embedded Linux | https://www.pengutronix.de |
> Vertretung West/Dortmund | Phone: +49-231-2826-924 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
Dario Binacchi
Embedded Linux Developer
dario.binacchi@xxxxxxxxxxxxxxxxxxxx
__________________________________
Amarula Solutions SRL
Via Le Canevare 30, 31100 Treviso, Veneto, IT
T. +39 042 243 5310
info@xxxxxxxxxxxxxxxxxxxx
www.amarulasolutions.com
