Coverity: mcp251xfd_dump_rx_ring(): Memory - illegal accesses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    e0ab3dd5f98f ("can: mcp251xfd: add dev coredump support")

Coverity reported the following:

*** CID 1503585:  Memory - illegal accesses  (OVERRUN)
/drivers/net/can/spi/mcp251xfd/mcp251xfd-dump.c: 190 in mcp251xfd_dump_rx_ring()
184     static void mcp251xfd_dump_rx_ring(const struct mcp251xfd_priv *priv,
185     				   struct mcp251xfd_dump_iter *iter)
186     {
187     	struct mcp251xfd_rx_ring *rx_ring;
188     	unsigned int i;
189
vvv     CID 1503585:  Memory - illegal accesses  (OVERRUN)
vvv     Overrunning array of 1 8-byte elements at element index 1 (byte offset 15) by dereferencing pointer "priv->rx + i".
190     	mcp251xfd_for_each_rx_ring(priv, rx_ring, i)
191     		mcp251xfd_dump_rx_ring_one(priv, iter, rx_ring);
192     }
193
194     static void mcp251xfd_dump_tx_ring(const struct mcp251xfd_priv *priv,
195     				   struct mcp251xfd_dump_iter *iter)

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@xxxxxxxxxxxx>
Addresses-Coverity-ID: 1503585 ("Memory - illegal accesses")
Fixes: e0ab3dd5f98f ("can: mcp251xfd: add dev coredump support")

Thanks for your attention!

-- 
Coverity-bot




[Index of Archives]     [Automotive Discussions]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]     [CAN Bus]

  Powered by Linux