On wo, 10 apr 2019 10:36:26 +0200, Oleksij Rempel wrote: > and add J1939_PGN_ADDRESS_COMMANDED define > > Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> > --- > include/uapi/linux/can/j1939.h | 5 +++-- > net/can/j1939/address-claim.c | 2 +- > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/can/j1939.h b/include/uapi/linux/can/j1939.h > index 0c76bd2caf90..160e960cdc7b 100644 > --- a/include/uapi/linux/can/j1939.h > +++ b/include/uapi/linux/can/j1939.h > @@ -20,8 +20,9 @@ > #define J1939_IDLE_ADDR 0xfe > #define J1939_NO_ADDR 0xff /* == broadcast or no addr */ > #define J1939_NO_NAME 0 > -#define J1939_PGN_REQUEST 0x0ea00 > -#define J1939_PGN_ADDRESS_CLAIMED 0x0ee00 > +#define J1939_PGN_ADDRESS_REQUEST 0x0ea00 /* Request for Address Claimed */ >From kernel point of view, the request PGN is only used in context of address claim, but j1939 defines it as a generic request pgn. The pgn to be requested, is in the 3 byte payload. Making it J1939_PGN_ADDRESS_REQUEST is wrong. > +#define J1939_PGN_ADDRESS_CLAIMED 0x0ee00 /* Address Claimed */ > +#define J1939_PGN_ADDRESS_COMMANDED 0x0fed8 /* Commanded Address */ Responding to commanded address is, IMO, definitely a userspace thing. So, I will never be used in kernel. Why is in the uapi header files? Adding all j1939 PGN definitions is a project on it own already.h Kind regards, Kurt
