It's straight forward filter handling, don't set mask if you're not
interested in some aspects of the address, No need to know the semantics
of J1939 here.
Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
---
net/can/j1939/socket.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/net/can/j1939/socket.c b/net/can/j1939/socket.c
index f212e8b19fc7..b24367bc4391 100644
--- a/net/can/j1939/socket.c
+++ b/net/can/j1939/socket.c
@@ -158,10 +158,6 @@ static bool j1939_sk_match_filter(struct j1939_sock *jsk,
/* receive all when no filters are assigned */
return true;
- /* Filters relying on the addr for static addressing _should_ get
- * packets from dynamic addressed ECU's too if they match their SA.
- * Sockets using dynamic addressing in their filters should not set it.
- */
for (; nfilter; ++f, --nfilter) {
if ((skcb->addr.pgn & f->pgn_mask) != f->pgn)
continue;
--
2.20.1
