On Thu, 25 Feb 2010, Nick Pelly wrote: > On Sun, Feb 21, 2010 at 11:53 PM, Ville Tervo <ville.tervo@xxxxxxxxx> wrote: > > Nick Pelly wrote: > >>>> > >>>> Attached is a new patch with the consistent bit logic. > >>>> > >>>> Comments? > >>> > >>> In order to keep backwards compatibility 1 should mean "don't allow this > >>> packet type" for all packets. Other wise old application with new kernel > >>> would not allow any packet types. > >> > >> The current patch achieves this backwards compatibility by assuming > >> that all packet types are allowed if the old sockaddr_sco struct is > >> used (it checks the size), or if sco_pkt_type is 0. > > > > OK. Then my concerns are gone. > > As best I can tell there are no objections. We're going ahead with this patch. > > http://android.git.kernel.org/?p=kernel/common.git;a=commit;h=3b077241e02041b1f03fee912896b8de1d7ac096 FWIW (I am not a Linux, Android or BlueZ developer) I think abusing the socket address structure for this is wrong and a socket option should be used to set options for the socket. In general, the "Address Family" AF_BLUETOOTH domain sockets should all use the same socket address structure. That BlueZ/Linux does not and never has done so should be considered a bug. regards, iain -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
