On Thu, Feb 13, 2025 at 01:04:03PM -0800, Anjelique Melendez wrote: > Add support for TEMP_ALARM LITE PMIC peripherals. This subtype > utilizes a pair of registers to configure a warning interrupt > threshold temperature and an automatic hardware shutdown > threshold temperature. > > Signed-off-by: David Collins <david.collins@xxxxxxxxxxxxxxxx> > Signed-off-by: Anjelique Melendez <anjelique.melendez@xxxxxxxxxxxxxxxx> > --- > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 204 +++++++++++++++++++- > 1 file changed, 203 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > index a10f368f2039..081db1a85b8a 100644 > --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > @@ -22,6 +22,7 @@ > #define QPNP_TM_REG_TYPE 0x04 > #define QPNP_TM_REG_SUBTYPE 0x05 > #define QPNP_TM_REG_STATUS 0x08 > +#define QPNP_TM_REG_IRQ_STATUS 0x10 Is it a generic register or a LITE one? The rest LGTM > #define QPNP_TM_REG_SHUTDOWN_CTRL1 0x40 > #define QPNP_TM_REG_ALARM_CTRL 0x46 > -- With best wishes Dmitry