Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 12 Aug 2023 at 00:56, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
> On 11.08.2023 23:35, Robert Marko wrote:
> > On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
> >>
> >> On 11.08.2023 23:01, Robert Marko wrote:
> >>> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
> >>> as they should be under the partitions subnode and use the generic
> >>> jedec,spi-nor compatible.
> >>>
> >>> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> >>> ---
> >> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"
> >
> > Hi,
> > I grepped the vendor U-Boot to make sure it's not being triggered off
> > the mx25l25635e
> > compatible but the only hit is the IC support itself.
> > MX25L25635 was just the original NOR IC Qualcomm used on the board so
> > to me it made
> > most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR
> > compatible.
> OK if dynamic identification works fine

It should work fine, datasheet is clear that its JEDEC compatible.
That being said, I dont actually have the board, just figured it was
time for a cleanup as
OpenWrt has been patching DK01 and DK04 for ages.

Regards,
Robert
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>
> Konrad



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux