On Tue, Jun 10, 2014 at 10:39:02AM -0700, Stephen Boyd wrote:
<snip>
> >> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
> >> index ab7b441..64fb298 100644
> >> --- a/drivers/soc/qcom/qcom_gsbi.c
> >> +++ b/drivers/soc/qcom/qcom_gsbi.c
> >> @@ -22,44 +22,63 @@
> >> #define GSBI_CTRL_REG 0x0000
> >> #define GSBI_PROTOCOL_SHIFT 4
> >>
> >> +struct gsbi_info {
> >> + struct clk *hclk;
> >> + u32 mode;
> >> + u32 crci;
> >> +};
>
> What does mode and crci have to do with this patch? Can't we just put
> the clock into the platform data?
I second this notion.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
