On Wed, Feb 07, 2024 at 12:11:24PM -0800, Jakub Kicinski wrote: > On Wed, 7 Feb 2024 11:14:08 -0800 Joe Damato wrote: > > > Why do we need u64 for usecs? I think u16 would do, and u32 would give > > > a very solid "engineering margin". If it was discussed in previous > > > versions I think it's worth explaining in the commit message. > > > > In patch 4/4 the value is limited to U32_MAX, but if you prefer I use a u32 > > here instead, I can make that change. > > Unless you have a clear reason not to, I think using u32 would be more > natural? If my head math is right the range for u32 is 4096 sec, > slightly over an hour? I'd use u32 and limit it to S32_MAX. OK, that seems fine. Sorry for the noob question, but since that represents a fucntional change to patch 4/4, I believe I would need to drop Jiri's Reviewed-by, is that right?
