On Wed, 7 Feb 2024 11:16:03 -0800 Joe Damato wrote: > > > netdev maintainers: Jiri marked this with Reviewed-by, but was this review > > > what caused "Changes Requested" to be the status set for this patch set in > > > patchwork? > > > > > > If needed, I'll send a v7 with the changes Jiri suggested and add the > > > "Reviewed-by" since the changes are cosmetic, but I wanted to make sure > > > this was the reason. > > > > Yes, I think that's it. > > OK, thanks for letting me know. I wasn't sure if it was because of the > netdev/source_inline which marked 1/4 as "fail" because of the inlines > added. > > Does that need to be changed, as well? For background our preference is to avoid using static inline in C sources, unless the author compiled the code and actually confirmed the code doesn't get inlined correctly. But it's not a hard requirement, and technically the code is under fs/. In general the patchwork checks are a bit noisy, see here the top left graph of how many of the patches we merge are "all green": https://netdev.bots.linux.dev/checks.html Some of the checks are also largely outside of our control (checkpatch) so consider the patchwork checks as automation for maintainers. The maintainers should respond on the list if any of the failures are indeed legit.
