On Sun, Oct 6, 2013 at 7:32 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Sun, Oct 06, 2013 at 07:27:48PM -0500, Felipe Contreras wrote: > >> If _you_ want to add comments for each entry in the list you can do so >> after this patch is applied. > > If you want to participate in a collaborative development effort you > should pay attention to other people's concerns. I did that when I listened to your comment, and I argued against it. Disagreeing is not the same as not paying attention. > I don't get the final > say in whether or not this patch gets merged, but there's a decent > chance that I'm going to be the one who has to remove the entries again > once the backlight mess is fixed up. My life would be significantly > easier if the entries are unambiguously identified in such a way that I > can remove them without having to dig through git history to figure out > where each came from. And a *single* comment on top of this group entries achieves that just fine. You haven't provided a single argument as to why that wouldn't be the case. In fact, you are the one that is not paying attention. > Is that really an unreasonable request? That wasn't a request, that was an explanation of what would make your life easier. And if uncommented entries is a problem for you, you already have that problem, because the entries to remove are already there, uncommented. The original patch I sent had a comment, so that's not my fault. This patch would not make your life any harder, so that is a red herring. The problem is already there. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
