On Sun, Oct 06, 2013 at 07:50:18PM -0500, Felipe Contreras wrote: > On Sun, Oct 6, 2013 at 7:32 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > I don't get the final > > say in whether or not this patch gets merged, but there's a decent > > chance that I'm going to be the one who has to remove the entries again > > once the backlight mess is fixed up. My life would be significantly > > easier if the entries are unambiguously identified in such a way that I > > can remove them without having to dig through git history to figure out > > where each came from. > > And a *single* comment on top of this group entries achieves that just > fine. You haven't provided a single argument as to why that wouldn't > be the case. No, it demonstrably doesn't. The comments that do exist refer to only a subset of the entries underneath them. Having a per-entry comment is significantly clearer. Given that I have to delete things from this file and you don't, I have absolutely no idea why you refuse to believe me on this. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html