On Fri, 2008-10-31 at 22:54 +0800, Alexey Starikovskiy wrote: > Alan Jenkins wrote: > > Alexey Starikovskiy wrote: > >> Alan Jenkins wrote: > >>> Alexey Starikovskiy wrote: > >>>> Alan Jenkins wrote: > >>>>> Alexey Starikovskiy wrote: > >>>>>> Alan Jenkins wrote: > >>>>>>> Well, that didn't work. > >>>>>> Pity... > >>>>>> Could you produce a debug log from EC? > >>>>>> Probably it's a good time to open a new bug report... > >>>>> <http://bugzilla.kernel.org/show_bug.cgi?id=11917> > >>>>> "Asus Eee PC hotkeys stop working after prolonged usage" > >>>>> > >>>>> I stuck at it, found a reliable test and bisected successfully. > >>>>> 2.6.28-rc2 is broken, but I can fix it by reverting the bad commit. > >>>>> (There were some conflicts, I fixed up the dock driver manually and > >>>>> avoided building the rest). > >>>> Alan, to make things clear -- reverting following commit makes EC work > >>>> without > >>>> a problem? > >>>> > >>> > >>> Yes, that's right. > >> Great! > >> What kernel version is that -- 32 or 64? Thanks for the patch. It seems that the code path in the function of ec_parse_device is incorrect. Whether the ec->global_lock is assigned to a value should be based on the returned value of acpi_evaluate_integer(handle, "_GLK", NULL, &tmp). If AE_OK is returned, the ec->global_lock is assigned to true. Otherwise it should be False. Is this OK? Thanks. > > > > 32 bit, my EeePC doesn't do 64. > is the attached patch enough to fix ? > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
