New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1529968:  Null pointer dereferences  (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1529968:  Null pointer dereferences  (NULL_RETURNS)
/sc/source/core/data/column3.cxx: 2579 in <unnamed>::FilterEntriesHandler::processCell(const ScColumn &, int, ScRefCellValue &)()
2573             sal_uLong nFormat = mrColumn.GetNumberFormat(mrColumn.GetDoc().GetNonThreadedContext(), nRow);
2574             OUString aStr = ScCellFormat::GetInputString(rCell, nFormat, *pFormatter, mrColumn.GetDoc(), mbFiltering);
2575     
2576             // Colors
2577             ScAddress aPos(rColumn.GetCol(), nRow, rColumn.GetTab());
2578             ScTable* pTable = rColumn.GetDoc().FetchTable(rColumn.GetTab());
>>>     CID 1529968:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "nullptr" "pTable" when calling "GetCellTextColor".
2579             mrFilterEntries.addTextColor(pTable->GetCellTextColor(aPos));
2580             mrFilterEntries.addBackgroundColor(pTable->GetCellBackgroundColor(aPos));
2581     
2582             if (rCell.hasString())
2583             {
2584                 mrFilterEntries.push_back(ScTypedStrData(std::move(aStr), 0.0, 0.0, ScTypedStrData::Standard, false, mbFilteredRow));

** CID 1529967:  Uninitialized variables  (UNINIT)


________________________________________________________________________________________________________
*** CID 1529967:  Uninitialized variables  (UNINIT)
/sc/source/core/data/sortparam.cxx: 74 in ScSortParam::Clear()()
68     
69         aKeyState.bDoSort = false;
70         aKeyState.nField = 0;
71         aKeyState.bAscending = true;
72     
73         // Initialize to default size
>>>     CID 1529967:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "aKeyState". Field "aKeyState.aColorSortMode" is uninitialized when calling "assign".
74         maKeyState.assign( DEFSORT, aKeyState );
75     }
76     
77     ScSortParam& ScSortParam::operator=( const ScSortParam& r )
78     {
79         nCol1           = r.nCol1;

** CID 1529966:    (RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in BitmapMosaicFilter::execute(const BitmapEx &) const()
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in BitmapMosaicFilter::execute(const BitmapEx &) const()


________________________________________________________________________________________________________
*** CID 1529966:    (RESOURCE_LEAK)
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in BitmapMosaicFilter::execute(const BitmapEx &) const()
172                     aBitmap = *pNewBmp;
173     
174                     aBitmap.SetPrefMapMode(aMap);
175                     aBitmap.SetPrefSize(aPrefSize);
176                 }
177             }
>>>     CID 1529966:    (RESOURCE_LEAK)
>>>     Variable "pWriteAcc" going out of scope leaks the storage it points to.
178         }
179     
180         if (bRet)
181             return BitmapEx(aBitmap);
182     
183         return BitmapEx();
184     }
185     
/vcl/source/bitmap/BitmapMosaicFilter.cxx: 178 in BitmapMosaicFilter::execute(const BitmapEx &) const()
172                     aBitmap = *pNewBmp;
173     
174                     aBitmap.SetPrefMapMode(aMap);
175                     aBitmap.SetPrefSize(aPrefSize);
176                 }
177             }
>>>     CID 1529966:    (RESOURCE_LEAK)
>>>     Variable "pWriteAcc" going out of scope leaks the storage it points to.
178         }
179     
180         if (bRet)
181             return BitmapEx(aBitmap);
182     
183         return BitmapEx();
184     }
185     

** CID 1529965:    (UNINIT)
/sc/source/core/data/sortparam.cxx: 199 in ScSortParam::ScSortParam(const ScSubTotalParam &, const ScSortParam&)()
/sc/source/core/data/sortparam.cxx: 181 in ScSortParam::ScSortParam(const ScSubTotalParam &, const ScSortParam&)()


________________________________________________________________________________________________________
*** CID 1529965:    (UNINIT)
/sc/source/core/data/sortparam.cxx: 199 in ScSortParam::ScSortParam(const ScSubTotalParam &, const ScSortParam&)()
193                 if (!bDouble)               // do not enter a field twice
194                 {
195                     ScSortKeyState key;
196                     key.bDoSort = true;
197                     key.nField = nThisField;
198                     key.bAscending = rOld.maKeyState[i].bAscending;
>>>     CID 1529965:    (UNINIT)
>>>     Using uninitialized value "key". Field "key.aColorSortMode" is uninitialized when calling "push_back". [Note: The source code implementation of the function has been overridden by a builtin model.]
199                     maKeyState.push_back(key);
200                 }
201             }
202     }
203     
204     ScSortParam::ScSortParam( const ScQueryParam& rParam, SCCOL nCol ) :
/sc/source/core/data/sortparam.cxx: 181 in ScSortParam::ScSortParam(const ScSubTotalParam &, const ScSortParam&)()
175                 if (rSub.bGroupActive[i])
176                 {
177                     ScSortKeyState key;
178                     key.bDoSort = true;
179                     key.nField = rSub.nField[i];
180                     key.bAscending = rSub.bAscending;
>>>     CID 1529965:    (UNINIT)
>>>     Using uninitialized value "key". Field "key.aColorSortMode" is uninitialized when calling "push_back". [Note: The source code implementation of the function has been overridden by a builtin model.]
181                     maKeyState.push_back(key);
182                 }
183     
184         //  then the old settings
185         for (i=0; i < rOld.GetSortKeyCount(); i++)
186             if (rOld.maKeyState[i].bDoSort)

** CID 1529964:  Uninitialized variables  (UNINIT)
/sc/source/core/data/sortparam.cxx: 220 in ScSortParam::ScSortParam(const ScQueryParam &, short)()


________________________________________________________________________________________________________
*** CID 1529964:  Uninitialized variables  (UNINIT)
/sc/source/core/data/sortparam.cxx: 220 in ScSortParam::ScSortParam(const ScQueryParam &, short)()
214     
215         ScSortKeyState aKeyState;
216         aKeyState.bDoSort = true;
217         aKeyState.nField = nCol;
218         aKeyState.bAscending = true;
219     
>>>     CID 1529964:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "aKeyState". Field "aKeyState.aColorSortMode" is uninitialized when calling "push_back". [Note: The source code implementation of the function has been overridden by a builtin model.]
220         maKeyState.push_back( aKeyState );
221     
222         // Set the rest
223         aKeyState.bDoSort = false;
224         aKeyState.nField = 0;
225     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Dj1di_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi8z8nKH1RdzV8VMUiT8zaOFk8y4AnWiziNNUB6aC3gKVmzDhcF-2FWKZ4Uewf08cZK1d8z8EoHGJbaEA8TVdXxsYXAh6CNaABzClFdsCSpHy5A3wUbz0RAm9vYNlOcm-2BLpy9UXXYf8dbqfSCTNQkoylghBuNp1Q0Xl6c0NQauNFJmo-3D