Hello Paolo,
With reference to Boris's ack below, are you going to go ahead and queue
this patch-set to kvm tree ?
Or do you want me to work on improving on or fixing anything on this
patch-set?
Thanks,
Ashish
On 9/29/21 11:44 AM, Borislav Petkov wrote:
On Tue, Sep 28, 2021 at 07:26:32PM +0000, Kalra, Ashish wrote:
Yes that’s what I mentioned to Boris.
Right, and as far as I'm concerned, the x86 bits look ok to me and I'm
fine with this going through the kvm tree.
There will be a conflict with this:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.kernel.org%2Fr%2F20210928191009.32551-1-bp%40alien8.de&data=04%7C01%7CAshish.Kalra%40amd.com%7Cbfa692635e9d4247a8f708d9833e8bcd%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637685126945432007%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vZU8ZijdqiSiVpCquIMqu2yz3Z7sWgD3vvNiiQyszzo%3D&reserved=0
resulting in:
arch/x86/kernel/kvm.c: In function ‘setup_efi_kvm_sev_migration’:
arch/x86/kernel/kvm.c:563:7: error: implicit declaration of function ‘sev_active’; did you mean ‘cpu_active’? [-Werror=implicit-function-declaration]
563 | if (!sev_active() ||
| ^~~~~~~~~~
| cpu_active
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:277: arch/x86/kernel/kvm.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [scripts/Makefile.build:540: arch/x86/kernel] Error 2
make: *** [Makefile:1868: arch/x86] Error 2
make: *** Waiting for unfinished jobs....
but Paolo and I will figure out what to do - I'll likely have a separate
branch out which he can merge and that sev_active() will need to be
converted to
if (!cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT))
which is trivial.
Thx.
