On 09/23/15 at 01:26pm, Baoquan He wrote: > On 09/23/15 at 01:14pm, Minfei Huang wrote: > > On 09/23/15 at 10:49am, Baoquan He wrote: > > > This is weird, user really don't need to know each file. I saw you added > > > a new file kexec_internal.h and all three files includes it. Why not doing > > > it there to make it the same as before? > > > > The output message format is incorrect, if other *.c (except for kexec*) > > include the kexec_internal.h. > > No, I assume Dave added kexec_internal.h not to be used by other *.c. > It should be only used by kexec*.c > > > > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > > How about defining the format like above in each *.c? Ok. I can split this patch as two patches One for cleanup, other to fix the prefix issue. Thanks Minfei