On 09/15/15 at 11:08am, Minfei Huang wrote: > On 09/14/15 at 04:44pm, Dave Young wrote: > > On 09/14/15 at 03:50pm, Minfei Huang wrote: > > > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > > > Minfei Huang <mnfhuang at gmail.com> writes: > > > > > > > > > kexec output message misses the prefix "kexec", when Dave Young split > > > > > the kexec code. To keep the same format, add the prefix "kexec" to > > > > > output message. > > > > > > > > What of kexec_core? What of the messages that already have a prefix? > > > > > > > > > > Hi, Eric. > > > > > > Last commit(2965fa), Dave Young (dyoung at redhatcom) split the previous > > > kernel/kexec.c into three pieces(kexec_core.c, kexec_file.c, kexec.c). > > > The common functions used by both kexec and kexec_file are placed in > > > file kernel/kexec_core.c. > > > > > > The format of the output message likes "kexec: SYSC_kexec_load: hello, > > > world" previously. Due to the missing prefix "kexec", now it like > > > "SYSC_kexec_load: hello, world". > > > > > > Dave Young misses the Macro pr_fmt to define the prefix output message > > > in file kexec.c and kexec_file.c. I think the previous Macro was moved > > > into the file kexec_core.c when Dave did the splitting. > > > > I'm not sure it is proper to add prefix "kexec: " in all kexec*.c, so > > only keep it in kexec_core.c. > > > > There's already printks with prefix like "Kexec:", "crashkernel:" and > > other strings. Adding another prefix before them looks odd. So either remove > > the prefix in kexec_core, or remove other prefixes already exists in kexec*.c > > I would prefix to remove the "kexec:" prefix in kexec_core.c > > Hi, Dave. > > How about removing all of the prefix "crashkernel" in kexec_core. Thus > we can be consistent with the output message prefix "kexec". Ping, any comment is appreciate and helpful. Thanks Minfei
