On 09/14/15 at 03:50pm, Minfei Huang wrote: > On 09/13/15 at 11:52am, Eric W. Biederman wrote: > > Minfei Huang <mnfhuang at gmail.com> writes: > > > > > kexec output message misses the prefix "kexec", when Dave Young split > > > the kexec code. To keep the same format, add the prefix "kexec" to > > > output message. > > > > What of kexec_core? What of the messages that already have a prefix? > > > > Hi, Eric. > > Last commit(2965fa), Dave Young (dyoung at redhatcom) split the previous > kernel/kexec.c into three pieces(kexec_core.c, kexec_file.c, kexec.c). > The common functions used by both kexec and kexec_file are placed in > file kernel/kexec_core.c. > > The format of the output message likes "kexec: SYSC_kexec_load: hello, > world" previously. Due to the missing prefix "kexec", now it like > "SYSC_kexec_load: hello, world". > > Dave Young misses the Macro pr_fmt to define the prefix output message > in file kexec.c and kexec_file.c. I think the previous Macro was moved > into the file kexec_core.c when Dave did the splitting. I'm not sure it is proper to add prefix "kexec: " in all kexec*.c, so only keep it in kexec_core.c. There's already printks with prefix like "Kexec:", "crashkernel:" and other strings. Adding another prefix before them looks odd. So either remove the prefix in kexec_core, or remove other prefixes already exists in kexec*.c I would prefix to remove the "kexec:" prefix in kexec_core.c > > Thanks > Minfei > > > > Following is the format of output message now. > > > [ 140.290795] SYSC_kexec_load: hello, world > > > > > > Ideally, the format of output message likes below. > > > [ 140.291534] kexec: sanity_check_segment_list: hello, world > > > > > > Signed-off-by: Minfei Huang <mnfhuang at gmail.com> > > > --- > > > kernel/kexec.c | 2 ++ > > > kernel/kexec_file.c | 2 ++ > > > 2 files changed, 4 insertions(+) > > > > > > diff --git a/kernel/kexec.c b/kernel/kexec.c > > > index 4c5edc3..15351ba 100644 > > > --- a/kernel/kexec.c > > > +++ b/kernel/kexec.c > > > @@ -6,6 +6,8 @@ > > > * Version 2. See the file COPYING for more details. > > > */ > > > > > > +#define pr_fmt(fmt) "kexec: " fmt > > > + > > > #include <linux/capability.h> > > > #include <linux/mm.h> > > > #include <linux/file.h> > > > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > > > index 6a9a3f2..b1ad01b 100644 > > > --- a/kernel/kexec_file.c > > > +++ b/kernel/kexec_file.c > > > @@ -9,6 +9,8 @@ > > > * Version 2. See the file COPYING for more details. > > > */ > > > > > > +#define pr_fmt(fmt) "kexec: " fmt > > > + > > > #include <linux/capability.h> > > > #include <linux/mm.h> > > > #include <linux/file.h>
