On 1/16/23 2:14 PM, Pavel Begunkov wrote: > On 1/16/23 21:04, Jens Axboe wrote: >> On 1/16/23 12:47 PM, Pavel Begunkov wrote: >>> On 1/16/23 18:43, Jens Axboe wrote: >>>> On 1/16/23 9:48 AM, Pavel Begunkov wrote: >>>>> io_submit_flush_completions() may queue new requests for tw execution, >>>>> especially true for linked requests. Recheck the tw list for emptiness >>>>> after flushing completions. >>>> >>>> Did you check when it got lost? Would be nice to add a Fixes link? >>> >>> fwiw, not fan of putting a "Fixes" tag on sth that is not a fix. >> >> I'm not either as it isn't fully descriptive, but it is better than >> not having that reference imho. > > Agree, but it's also not great that it might be tried to be > backported. Maybe adding a link would be nicer? > > Link: https://lore.kernel.org/r/20220622134028.2013417-4-dylany@xxxxxx Only the auto-select bot would pick it, but I'm guessing it'll fail and that'll be the end of that. Normal stable additions need a cc stable as well, the fixes is not enough to trigger that. -- Jens Axboe