On 1/16/23 21:04, Jens Axboe wrote:
On 1/16/23 12:47 PM, Pavel Begunkov wrote:
On 1/16/23 18:43, Jens Axboe wrote:
On 1/16/23 9:48 AM, Pavel Begunkov wrote:
io_submit_flush_completions() may queue new requests for tw execution,
especially true for linked requests. Recheck the tw list for emptiness
after flushing completions.
Did you check when it got lost? Would be nice to add a Fixes link?
fwiw, not fan of putting a "Fixes" tag on sth that is not a fix.
I'm not either as it isn't fully descriptive, but it is better than
not having that reference imho.
Agree, but it's also not great that it might be tried to be
backported. Maybe adding a link would be nicer?
Link: https://lore.kernel.org/r/20220622134028.2013417-4-dylany@xxxxxx
Looks like the optimisation was there for normal task_work, then
disappeared in f88262e60bb9c ("io_uring: lockless task list").
DEFERRED_TASKRUN came later and this patch handles exclusively
deferred tw. I probably need to send a patch for normal tw as well.
So maybe just use that commit? I can make a note in the message on
how it relates.
--
Pavel Begunkov
