On Wed, Sep 02, 2015 at 03:46:40PM +0200, Takashi Iwai wrote: > On Wed, 02 Sep 2015 15:44:34 +0200, > Jani Nikula wrote: > > > > On Wed, 02 Sep 2015, Takashi Iwai <tiwai@xxxxxxx> wrote: > > > On Wed, 02 Sep 2015 11:02:42 +0200, > > > Jani Nikula wrote: > > >> > > >> >> Nitpick. I'd prefer some sharing with the similar blocks from the > > >> >> earlier patch. Also a debug message on n == 0 would be nice; you > > >> >> probably didn't notice your audio_config_get_rate() wasn't working > > >> >> right > > >> >> because this silently fell back to the automatic mode here. > > >> > > > >> > OK, I will add the msg. As you and Ville are insisting on > > >> > sharing code, I will do it in next version. > > >> > > >> Well, really, I'm fine with having that part duplicated as-is for now, > > >> we can fix it later. More important to focus on getting > > >> audio_config_get_rate() right. > > >> > > >> I don't know if you're still targeting v4.3 with this (up to Takashi I > > >> guess) we'll really need to wrap this up soon. > > > > > > I'm in favor of merging this into 4.3, so it'd be appreciated if Libin > > > can prepare the fixed version soonish, indeed. > > > > IIUC patches 1-3 would be useful on their own already, and a fixed > > version of patch 4 could follow. Just a thought. > > That's good, then I can take the first three patches. > > Daniel, would you like to review these three before I merge them? > I assumed your previous mail as a kind of ack to this series, too. fwiw ack on that plan, but given how much I made a mess out of these two series and mixed them up I wouldn't trust me anyway ;-) Once the code settles I'll rebase/backmerge so that I can apply the follow-up documentation/kerneldoc work that's still getting done. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
