On Wed, 02 Sep 2015 11:02:42 +0200, Jani Nikula wrote: > > >> Nitpick. I'd prefer some sharing with the similar blocks from the > >> earlier patch. Also a debug message on n == 0 would be nice; you > >> probably didn't notice your audio_config_get_rate() wasn't working > >> right > >> because this silently fell back to the automatic mode here. > > > > OK, I will add the msg. As you and Ville are insisting on > > sharing code, I will do it in next version. > > Well, really, I'm fine with having that part duplicated as-is for now, > we can fix it later. More important to focus on getting > audio_config_get_rate() right. > > I don't know if you're still targeting v4.3 with this (up to Takashi I > guess) we'll really need to wrap this up soon. I'm in favor of merging this into 4.3, so it'd be appreciated if Libin can prepare the fixed version soonish, indeed. thanks, Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
