Daniel Vetter writes: > On Wed, Sep 02, 2015 at 04:19:00PM +0200, Egbert Eich wrote: > > Hm I missed that this same register is also accessed by the irq handler > code, and it's not just that touching these bits can cause interrupts. So > yeah we need your patch, but it needs to be clearer in the commit message > that there's also trouble with concurrent register access to > PORT_HOTPLUG_EN. > > Also I think a commen in the code why we grab that spinlock would be good. > For that extracting a small helper to manipulate the register (like we do > with other irq mask registers with functions like ilk_update_gt_irq) would > be good - then we have just one place to put that commment. OK, I will come up with a suggestion. Cheers, Egbert. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/intel-gfx
