== Series Details == Series: drm/i915/display: platform identification with display->is.<PLATFORM> (rev3) URL : https://patchwork.freedesktop.org/series/135016/ State : warning == Summary == Error: dim checkpatch failed 49590e10bdf0 drm/i915/display: use a macro to initialize subplatforms 8be6dec8c79a drm/i915/display: use a macro to define platform enumerations -:20: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #20: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:18: +#define INTEL_DISPLAY_PLATFORMS(func) \ + func(PLATFORM_UNINITIALIZED) \ + /* Display ver 2 */ \ + func(I830) \ + func(I845G) \ + func(I85X) \ + func(I865G) \ + /* Display ver 3 */ \ + func(I915G) \ + func(I915GM) \ + func(I945G) \ + func(I945GM) \ + func(G33) \ + func(PINEVIEW) \ + /* Display ver 4 */ \ + func(I965G) \ + func(I965GM) \ + func(G45) \ + func(GM45) \ + /* Display ver 5 */ \ + func(IRONLAKE) \ + /* Display ver 6 */ \ + func(SANDYBRIDGE) \ + /* Display ver 7 */ \ + func(IVYBRIDGE) \ + func(VALLEYVIEW) \ + func(HASWELL) \ + /* Display ver 8 */ \ + func(BROADWELL) \ + func(CHERRYVIEW) \ + /* Display ver 9 */ \ + func(SKYLAKE) \ + func(BROXTON) \ + func(KABYLAKE) \ + func(GEMINILAKE) \ + func(COFFEELAKE) \ + func(COMETLAKE) \ + /* Display ver 11 */ \ + func(ICELAKE) \ + func(JASPERLAKE) \ + func(ELKHARTLAKE) \ + /* Display ver 12 */ \ + func(TIGERLAKE) \ + func(ROCKETLAKE) \ + func(DG1) \ + func(ALDERLAKE_S) \ + /* Display ver 13 */ \ + func(ALDERLAKE_P) \ + func(DG2) \ + /* Display ver 14 (based on GMD ID) */ \ + func(METEORLAKE) \ + /* Display ver 20 (based on GMD ID) */ \ + func(LUNARLAKE) \ + /* Display ver 14.1 (based on GMD ID) */ \ + func(BATTLEMAGE) -:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #20: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:18: +#define INTEL_DISPLAY_PLATFORMS(func) \ + func(PLATFORM_UNINITIALIZED) \ + /* Display ver 2 */ \ + func(I830) \ + func(I845G) \ + func(I85X) \ + func(I865G) \ + /* Display ver 3 */ \ + func(I915G) \ + func(I915GM) \ + func(I945G) \ + func(I945GM) \ + func(G33) \ + func(PINEVIEW) \ + /* Display ver 4 */ \ + func(I965G) \ + func(I965GM) \ + func(G45) \ + func(GM45) \ + /* Display ver 5 */ \ + func(IRONLAKE) \ + /* Display ver 6 */ \ + func(SANDYBRIDGE) \ + /* Display ver 7 */ \ + func(IVYBRIDGE) \ + func(VALLEYVIEW) \ + func(HASWELL) \ + /* Display ver 8 */ \ + func(BROADWELL) \ + func(CHERRYVIEW) \ + /* Display ver 9 */ \ + func(SKYLAKE) \ + func(BROXTON) \ + func(KABYLAKE) \ + func(GEMINILAKE) \ + func(COFFEELAKE) \ + func(COMETLAKE) \ + /* Display ver 11 */ \ + func(ICELAKE) \ + func(JASPERLAKE) \ + func(ELKHARTLAKE) \ + /* Display ver 12 */ \ + func(TIGERLAKE) \ + func(ROCKETLAKE) \ + func(DG1) \ + func(ALDERLAKE_S) \ + /* Display ver 13 */ \ + func(ALDERLAKE_P) \ + func(DG2) \ + /* Display ver 14 (based on GMD ID) */ \ + func(METEORLAKE) \ + /* Display ver 20 (based on GMD ID) */ \ + func(LUNARLAKE) \ + /* Display ver 14.1 (based on GMD ID) */ \ + func(BATTLEMAGE) total: 1 errors, 0 warnings, 1 checks, 124 lines checked 2476aacca30b drm/i915/display: join the platform and subplatform enums cb22b2f36651 drm/i915/display: add display platforms structure with platform members -:66: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #66: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:105: +#define __MEMBER(name) unsigned long name:1; -:67: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #67: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:106: +#define __COUNT(x) 1 + -:67: WARNING:MACRO_ARG_UNUSED: Argument 'x' is not used in function-like macro #67: FILE: drivers/gpu/drm/i915/display/intel_display_device.h:106: +#define __COUNT(x) 1 + total: 1 errors, 2 warnings, 0 checks, 59 lines checked b04a2536fb37 drm/i915/display: add platforms "is" member to struct intel_display aef1eff07425 drm/i915/display: remove the display platform enum as unnecessary d93f125cade6 drm/i915/display: consider HSW/BDW ULX to also be ULT -:41: WARNING:LONG_LINE: line length of 103 exceeds 100 columns #41: FILE: drivers/gpu/drm/i915/display/intel_display_device.c:539: + { SUBPLATFORM(BROADWELL, ULT), SUBPLATFORM(BROADWELL, ULX), .pciidlist = bdw_ulx_ids }, total: 0 errors, 1 warnings, 0 checks, 18 lines checked c1c2e8951d99 drm/i915/display: keep subplatforms next to their platforms 562e204f4251 drm/i915/bios: use display->is.PLATFORM instead of IS_PLATFORM()
