From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
The current check just asserts that we need FEC to use DSC
with (non-eDP) DP-SST. But MST also needs FEC for DSC. Just
check for !eDP instead to cover all the cases correctly.
v2: DP2/UHBR always uses FEC even though we don't flag it (Jani)
Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
---
drivers/gpu/drm/i915/display/intel_dp.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 2cde8ac513bb..d411538118f8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1377,10 +1377,15 @@ static bool intel_dp_supports_fec(struct intel_dp *intel_dp,
drm_dp_sink_supports_fec(intel_dp->fec_capable);
}
+static bool intel_dp_is_fec_enabled(const struct intel_crtc_state *crtc_state)
+{
+ return intel_dp_is_uhbr(crtc_state) || crtc_state->fec_enable;
+}
+
static bool intel_dp_supports_dsc(struct intel_dp *intel_dp,
const struct intel_crtc_state *crtc_state)
{
- if (intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP) && !crtc_state->fec_enable)
+ if (!intel_dp_is_edp(intel_dp) && !intel_dp_is_fec_enabled(crtc_state))
return false;
return intel_dsc_source_support(crtc_state) &&
@@ -2127,6 +2132,7 @@ int intel_dp_dsc_compute_config(struct intel_dp *intel_dp,
}
pipe_config->fec_enable = !intel_dp_is_edp(intel_dp) &&
+ !intel_dp_is_uhbr(pipe_config) &&
intel_dp_supports_fec(intel_dp, pipe_config);
if (!intel_dp_supports_dsc(intel_dp, pipe_config))
--
2.41.0
