Hi, > >>> This patch replaces all occurences of the form > >>> intel_uncore_write(reg, intel_uncore_read(reg) OP val) > >>> with intel_uncore_rmw. > >>> > >>> Signed-off-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx> > >> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> > >> > >> There are some lines that go over 80 characters... do you mind if I fix them > >> before pushing it? > > > > No problem, I guess you know that for some time the 'hard' limit has > > been raised to 100 chars/line [1], and this is for aesthetic reasons :) > > If you do, please follow advice from Ville to break the line after the > > 2nd argument - to keep 'clear' and 'set' args on the same line, if possible. > > Please don't get into the habit of changing stuff while pushing. Please > prefer pushing stuff that was sent to the list and the CI crunched > through as-is. > > Changing the commit message is fine. Doing some glaring > comment/whitespace fixes is acceptable. But going through entire patches > and fixing issues while pushing, not so much. OK, will leave it as it is. > And in this case in particular, please don't go out of your way to limit > to 80 characters. All right! I won't enforce it! Thanks Jani, Andi > BR, > Jani. > > > > > [1]: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 PS Hard habits are hard to die: I still like the 80 characters because they force programmers to write cleaner code and, as a tiling wm user, I find it more convenient.
