On Mon, 24 Oct 2022, Andrzej Hajda <andrzej.hajda@xxxxxxxxx> wrote: > Hi, > > Thx for review. > > On 21.10.2022 20:31, Andi Shyti wrote: >> Hi Andrzej, >> >> On Wed, Oct 19, 2022 at 04:38:17PM +0200, Andrzej Hajda wrote: >>> This patch replaces all occurences of the form >>> intel_uncore_write(reg, intel_uncore_read(reg) OP val) >>> with intel_uncore_rmw. >>> >>> Signed-off-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx> >> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> >> >> There are some lines that go over 80 characters... do you mind if I fix them >> before pushing it? > > No problem, I guess you know that for some time the 'hard' limit has > been raised to 100 chars/line [1], and this is for aesthetic reasons :) > If you do, please follow advice from Ville to break the line after the > 2nd argument - to keep 'clear' and 'set' args on the same line, if possible. Please don't get into the habit of changing stuff while pushing. Please prefer pushing stuff that was sent to the list and the CI crunched through as-is. Changing the commit message is fine. Doing some glaring comment/whitespace fixes is acceptable. But going through entire patches and fixing issues while pushing, not so much. And in this case in particular, please don't go out of your way to limit to 80 characters. BR, Jani. > > [1]: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > Regards > Andrzej > >> >> Andi > -- Jani Nikula, Intel Open Source Graphics Center
