Re: [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thx for review.

On 21.10.2022 20:31, Andi Shyti wrote:
Hi Andrzej,

On Wed, Oct 19, 2022 at 04:38:17PM +0200, Andrzej Hajda wrote:
This patch replaces all occurences of the form
intel_uncore_write(reg, intel_uncore_read(reg) OP val)
with intel_uncore_rmw.

Signed-off-by: Andrzej Hajda <andrzej.hajda@xxxxxxxxx>
Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>

There are some lines that go over 80 characters... do you mind if I fix them
before pushing it?

No problem, I guess you know that for some time the 'hard' limit has been raised to 100 chars/line [1], and this is for aesthetic reasons :) If you do, please follow advice from Ville to break the line after the 2nd argument - to keep 'clear' and 'set' args on the same line, if possible.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144

Regards
Andrzej


Andi




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux