Thank you for your consideration. It's my pleasure. Regards William -----Original Message----- From: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> Sent: Tuesday, November 9, 2021 4:05 PM To: Tseng, William <william.tseng@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx Cc: Tseng, William <william.tseng@xxxxxxxxx>; Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx>; Kulkarni, Vandita <vandita.kulkarni@xxxxxxxxx>; Lee, Shawn C <shawn.c.lee@xxxxxxxxx>; Chiou, Cooper <cooper.chiou@xxxxxxxxx> Subject: Re: [PATCH] drm/i915/dsi: disable lpdt if it is not enabled On Tue, 09 Nov 2021, William Tseng <william.tseng@xxxxxxxxx> wrote: > Avoid setting LP_DATA_TRANSFER when enable_lpdt is false > > Cc: Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> > Cc: Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx> > Cc: Lee Shawn C <shawn.c.lee@xxxxxxxxx> > Cc: Cooper Chiou <cooper.chiou@xxxxxxxxx> > Signed-off-by: William Tseng <william.tseng@xxxxxxxxx> > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c > b/drivers/gpu/drm/i915/display/icl_dsi.c > index 168c84a74d30..31cea17481b1 100644 > --- a/drivers/gpu/drm/i915/display/icl_dsi.c > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c > @@ -183,6 +183,8 @@ static int dsi_send_pkt_hdr(struct intel_dsi_host > *host, > > if (enable_lpdt) > tmp |= LP_DATA_TRANSFER; > + else > + tmp &= ~LP_DATA_TRANSFER; > > tmp &= ~(PARAM_WC_MASK | VC_MASK | DT_MASK); > tmp |= ((packet->header[0] & VC_MASK) << VC_SHIFT); The read-modify-write we do here is perhaps not the brightnest idea, but the patch at hand probably is the most sensible first fix. Thanks, pushed to drm-intel-next. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center
