On Sat, 25 Jan 2020, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: > On Fri, 24 Jan 2020, Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> wrote: >> On Fri, Jan 24, 2020 at 01:54:58PM +0000, Chris Wilson wrote: >>> Quoting Jani Nikula (2020-01-24 13:25:21) >>> > Hey all, >>> > >>> > So I sent [1] to convert some forcewake register accessors... but what if we >>> > just ripped off the bandage once and for all? It's going to hurt, a lot, but >>> > we'd get it done. >>> > >>> > This completely rids us of the "dev_priv" dependency in display/. >>> > >>> > All the patches here are per-file and independent of each other. We could also >>> > pick and apply the ones that are least likely to conflict. >>> > >>> > Opinions? >>> > >>> > >>> > BR, >>> > Jani. >>> > >>> > >>> > PS. I didn't bother looking at the checkpatch warnings this may generate at this >>> > point. I just used the --linux-spacing option for spatch, and closed my eyes. I >>> > completely scripted the generation of the series, apart from just a couple of >>> > build fixes. >>> >>> Yup. Suck it all in, clean up with the usual code refreshes. >>> Schadenfreude-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> >>> >>> I've looked at a couple of patches to confirm that it does appear purely >>> mechanical, >>> Acked-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> >> >> Since it is purely mechanical with coccinelle, why not to make in only one patch? > > Because such a mega patch would conflict before being able to > merge. You'd have to block everything else. I don't think I'd be able to > merge these in one go either even if we wanted to. Indeed, I started pushing the patches, pushed all that applied, and eight will need a rebase. Thanks for the acks. BR, Jani. > >> Anyway: >> Acked-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > Thanks, > Jani. > >> >>> -Chris >>> _______________________________________________ >>> Intel-gfx mailing list >>> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx