✗ Fi.CI.CHECKPATCH: warning for mkwrite_device_info removal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: mkwrite_device_info removal
URL   : https://patchwork.freedesktop.org/series/52381/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5d13c3c4a414 drm/i915: Remove has_pooled_eu static initializer
fb31d94b767b drm/i915: Introduce runtime device info
-:315: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#315: FILE: drivers/gpu/drm/i915/intel_device_info.c:86:
+#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(info->name));

-:315: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#315: FILE: drivers/gpu/drm/i915/intel_device_info.c:86:
+#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(info->name));

-:571: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#571: FILE: drivers/gpu/drm/i915/intel_device_info.h:183:
+#define DEV_RUNTIME_INFO_FOR_EACH_FLAG(func) \
+	func(has_pooled_eu); \
+

-:639: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects?
#639: FILE: drivers/gpu/drm/i915/intel_display.h:108:
+#define sprite_name(p, s) ((p) * dev_priv->runtime_info.num_sprites[(p)] + (s) + 'A')

total: 0 errors, 2 warnings, 2 checks, 709 lines checked
4048ffe0db39 drm/i915: Move all runtime modified device info fields into runtime info
-:9: WARNING:TYPO_SPELLING: 'overriden' may be misspelled - perhaps 'overridden'?
#9: 
there, but can be overriden at runtime.

-:113: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#113: FILE: drivers/gpu/drm/i915/i915_drv.c:1665:
+	BUG_ON(device_info->__gen > BITS_PER_TYPE(device_info->gen_mask));

-:275: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects?
#275: FILE: drivers/gpu/drm/i915/i915_pci.c:33:
+#define GEN(x) .__gen = (x), .gen_mask = BIT((x) - 1)

total: 0 errors, 2 warnings, 1 checks, 972 lines checked
0f083e1ac103 drm/i915: Remove mkwrite_device_info
-:44: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#44: FILE: drivers/gpu/drm/i915/i915_drv.c:1657:
+	i915->info = device_info = match_info;

-:329: WARNING:LONG_LINE: line over 100 characters
#329: FILE: drivers/gpu/drm/i915/i915_reg.h:186:
+					      INTEL_INFO(dev_priv)->trans_offsets[TRANSCODER_A] + (reg) + \

-:332: WARNING:LONG_LINE: line over 100 characters
#332: FILE: drivers/gpu/drm/i915/i915_reg.h:189:
+					      INTEL_INFO(dev_priv)->cursor_offsets[PIPE_A] + (reg) + \

total: 0 errors, 2 warnings, 1 checks, 636 lines checked
5df06a41ec00 drm/i915: Move gen and platform mask to runtime device info
-:38: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
#38: FILE: drivers/gpu/drm/i915/i915_drv.c:1686:
+	BUG_ON(INTEL_GEN(i915) > BITS_PER_TYPE(runtime_info->gen_mask));

total: 0 errors, 1 warnings, 0 checks, 120 lines checked
f2178767efa7 drm/i915: Introduce subplatform concept
-:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#41: FILE: drivers/gpu/drm/i915/i915_drv.h:2380:
+#define IS_SUBPLATFORM(dev_priv, p, s) \
+	(IS_PLATFORM(dev_priv, p) && \
+	 ((dev_priv)->runtime_info.subplatform_mask & \
+	  BIT(INTEL_SUBPLATFORM_##s)))

-:164: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#164: FILE: drivers/gpu/drm/i915/intel_device_info.c:744:
+	} else if (IS_IRONLAKE(i915) && devid == 0x0046) {
+			info->subplatform_mask =

total: 0 errors, 1 warnings, 1 checks, 213 lines checked
a5943656b1ec drm/i915: Remove double underscore from static device info member names

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux