On Wed, 14 Feb 2018, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
> Remove the kerneldoc markup applied to non-kerneldoc comments and
> convert the multiline comments to the canonical style.
>
> drivers/gpu/drm/i915/intel_dvo.c:303: warning: Function parameter or member 'connector' not described in 'intel_dvo_detect'
> drivers/gpu/drm/i915/intel_dvo.c:303: warning: Function parameter or member 'force' not described in 'intel_dvo_detect'
> drivers/gpu/drm/i915/intel_dvo.c:382: warning: Function parameter or member 'encoder' not described in 'intel_dvo_get_current_mode'
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/intel_dvo.c | 28 +++++++++++++++-------------
> 1 file changed, 15 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
> index 59c066ca14e5..eb0c559b2715 100644
> --- a/drivers/gpu/drm/i915/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/intel_dvo.c
> @@ -245,7 +245,8 @@ static bool intel_dvo_compute_config(struct intel_encoder *encoder,
> intel_dvo->attached_connector->panel.fixed_mode;
> struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
>
> - /* If we have timings from the BIOS for the panel, put them in
> + /*
> + * If we have timings from the BIOS for the panel, put them in
> * to the adjusted mode. The CRTC will be set up for this mode,
> * with the panel scaling set up to source from the H/VDisplay
> * of the original mode.
> @@ -293,11 +294,6 @@ static void intel_dvo_pre_enable(struct intel_encoder *encoder,
> I915_WRITE(dvo_reg, dvo_val);
> }
>
> -/**
> - * Detect the output connection on our DVO device.
> - *
> - * Unimplemented.
> - */
> static enum drm_connector_status
> intel_dvo_detect(struct drm_connector *connector, bool force)
> {
> @@ -313,7 +309,8 @@ static int intel_dvo_get_modes(struct drm_connector *connector)
> const struct drm_display_mode *fixed_mode =
> to_intel_connector(connector)->panel.fixed_mode;
>
> - /* We should probably have an i2c driver get_modes function for those
> + /*
> + * We should probably have an i2c driver get_modes function for those
> * devices which will have a fixed set of modes determined by the chip
> * (TV-out, for example), but for now with just TMDS and LVDS,
> * that's not the case.
> @@ -371,7 +368,7 @@ static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
> .destroy = intel_dvo_enc_destroy,
> };
>
> -/**
> +/*
> * Attempts to get a fixed panel timing for LVDS (currently only the i830).
> *
> * Other chips with DVO LVDS will need to extend this to deal with the LVDS
> @@ -443,7 +440,8 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
> uint32_t dpll[I915_MAX_PIPES];
> enum port port;
>
> - /* Allow the I2C driver info to specify the GPIO to be used in
> + /*
> + * Allow the I2C driver info to specify the GPIO to be used in
> * special cases, but otherwise default to what's defined
> * in the spec.
> */
> @@ -454,7 +452,8 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
> else
> gpio = GMBUS_PIN_DPB;
>
> - /* Set up the I2C bus necessary for the chip we're probing.
> + /*
> + * Set up the I2C bus necessary for the chip we're probing.
> * It appears that everything is on GPIOE except for panels
> * on i830 laptops, which are on GPIOB (DVOA).
> */
> @@ -462,12 +461,14 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
>
> intel_dvo->dev = *dvo;
>
> - /* GMBUS NAK handling seems to be unstable, hence let the
> + /*
> + * GMBUS NAK handling seems to be unstable, hence let the
> * transmitter detection run in bit banging mode for now.
> */
> intel_gmbus_force_bit(i2c, true);
>
> - /* ns2501 requires the DVO 2x clock before it will
> + /*
> + * ns2501 requires the DVO 2x clock before it will
> * respond to i2c accesses, so make sure we have
> * have the clock enabled before we attempt to
> * initialize the device.
> @@ -525,7 +526,8 @@ void intel_dvo_init(struct drm_i915_private *dev_priv)
>
> intel_connector_attach_encoder(intel_connector, intel_encoder);
> if (dvo->type == INTEL_DVO_CHIP_LVDS) {
> - /* For our LVDS chipsets, we should hopefully be able
> + /*
> + * For our LVDS chipsets, we should hopefully be able
> * to dig the fixed panel mode out of the BIOS data.
> * However, it's in a different format from the BIOS
> * data on chipsets with integrated LVDS (stored in AIM
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
