Re: [i-g-t v2] assembler: Fix bashism in run-test.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 30, 2017 at 09:09:41AM -0400, Rhys Kidd wrote:
> [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string,
> use -n with a normal [ ].
> 
> Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI.
> 
> v2:
>  - keep this as a /bin/sh script (Joonas Lahtinen)
> 
> Fixes: c3863e19 ("assembler/test: Prep work for meson")
> CC: Daniel Vetter <daniel.vetter@xxxxxxxx>
> CC: Petri Latvala <petri.latvala@xxxxxxxxx>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> Signed-off-by: Rhys Kidd <rhyskidd@xxxxxxxxx>

Thanks for patch and the review!
Pushed.

-- 
Cheers,
Arek
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux