[i-g-t v2] assembler: Fix bashism in run-test.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[[ a != b ]] is a bashism. As it's just comparing $1 to an empty string,
use -n with a normal [ ].

Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI.

v2:
 - keep this as a /bin/sh script (Joonas Lahtinen)

Fixes: c3863e19 ("assembler/test: Prep work for meson")
CC: Daniel Vetter <daniel.vetter@xxxxxxxx>
CC: Petri Latvala <petri.latvala@xxxxxxxxx>
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Signed-off-by: Rhys Kidd <rhyskidd@xxxxxxxxx>
---
 assembler/test/run-test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/assembler/test/run-test.sh b/assembler/test/run-test.sh
index 0a5252a8..b06e1044 100644
--- a/assembler/test/run-test.sh
+++ b/assembler/test/run-test.sh
@@ -5,7 +5,7 @@ BUILDDIR=${top_builddir-`pwd`}
 
 test="TEST"
 
-if [[ "$1" != "" ]] ; then
+if [ -n "$1" ] ; then
 	test="$1"
 fi
 
-- 
2.14.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux