Re: [i-g-t] assembler: Fix bashism in run-test.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2017-10-28 at 20:20 -0400, Rhys Kidd wrote:
> [[ a != b ]] is a bashism. As it's just comparing $1 to an empty string,
> use -n with a normal [ ].
> 
> Noticed whilst testing meson builds. /bin/sh is apparently dash in Intel's CI.
> 
> Also change the script to #!/bin/bash to avoid having to babysit bashism later.

Just leave the shebang as it is, then this is;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux