Oh! indeed! Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> On Thu, Jun 29, 2017 at 8:36 AM, Imre Deak <imre.deak@xxxxxxxxx> wrote: > Bspec requires a 10 us delay after disabling power well 1 and - if not > toggled on-demand - the AUX IO power wells during display uninit. > > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c > index efe80ed..fd59016 100644 > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c > @@ -2701,6 +2701,8 @@ static void skl_display_core_uninit(struct drm_i915_private *dev_priv) > intel_power_well_disable(dev_priv, well); > > mutex_unlock(&power_domains->lock); > + > + usleep_range(10, 30); /* 10 us delay per Bspec */ > } > > void bxt_display_core_init(struct drm_i915_private *dev_priv, > @@ -2758,6 +2760,8 @@ void bxt_display_core_uninit(struct drm_i915_private *dev_priv) > intel_power_well_disable(dev_priv, well); > > mutex_unlock(&power_domains->lock); > + > + usleep_range(10, 30); /* 10 us delay per Bspec */ > } > > #define CNL_PROCMON_IDX(val) \ > @@ -2859,6 +2863,8 @@ static void cnl_display_core_uninit(struct drm_i915_private *dev_priv) > intel_power_well_disable(dev_priv, well); > mutex_unlock(&power_domains->lock); > > + usleep_range(10, 30); /* 10 us delay per Bspec */ > + > /* 5. Disable Comp */ > val = I915_READ(CHICKEN_MISC_2); > val |= COMP_PWR_DOWN; > -- > 2.7.4 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx