[Last-Call] Re: Yangdoctors last call review of draft-ietf-bfd-large-packets-07

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 13, 2024 at 06:37:15PM +0000, Jeff Haas wrote:
> Jürgen,
> 
> 
> On 5/13/24, 11:56, "Jürgen Schönwälder" <jschoenwaelder@xxxxxxxxxxxxxxxx <mailto:jschoenwaelder@xxxxxxxxxxxxxxxx>ersity> wrote:
> > "The padded PDU size for the encapsulated BFD control packets.
> > The minimum size is 24 or 26; see Section 6.8.6 of RFC 5880.
> > The maximum PDU size may be limited by the supported interface
> > MTU of the system.";
> >
> >
> > Perhaps you meant the "The size of encapsulated and padded BFD control
> > packets"? I may have also been mislead by the "minimum size is 24 or
> > 26" since this seems to be the minimum BFD control packet size without
> > any encapsulation. In the last sentence, did you mean the "maximum
> > padded PDU size"?
> 
> How about the following?
> 
>      description
> -      "The padded PDU size for the encapsulated BFD control packets.
> -       The minimum size is 24 or 26; see Section 6.8.6 of RFC 5880.
> -       The maximum PDU size may be limited by the supported interface
> +      "The size of the padded and encapsulated BFD control packets
> +       to be transmitted at layer 3.  The BFD minimum control packet
> +       size is 24 or 26 octets; see Section 6.8.6 of RFC 5880.

Thanks, I think this is much clearer.

> +       The effective padded-pdu-size per BFD session will be
> +       increased from the configured value to the minimum sized
> +       packet for that encapsulation capable of carrying the BFD
> +       control packet.

I assume this paragraph only applies if the configured padded PDU size
is smaller than the achievable encapsulated PDU size. If so, it may
make this condition clearer?

  If the configured padded PDU size is smaller than the minimum sized
  packet of a given BFD session, then the minimum sized packet for the
  session will be used.

Or change the "will be" to "may be" as I sense this increase only
applies if the padded PDU size is smaller than the minimum necessary
for a given BFD session.

> +       The maximum padded PDU size may be limited by the supported interface

Is it a configuration error to configure a padded PDU size that is
impossible for a given BFD session / interface? Or will any large
value be valid configuration since implementations will silently
attempt to use the largest possible value for a given BFD session if
the configured padded PDU size is too large?

Sorry for this level of nitpicking.

/js

-- 
Jürgen Schönwälder              Constructor University Bremen gGmbH
Phone: +49 421 200 3587         Campus Ring 1 | 28759 Bremen | Germany

-- 
last-call mailing list -- last-call@xxxxxxxx
To unsubscribe send an email to last-call-leave@xxxxxxxx




[Index of Archives]     [IETF Annoucements]     [IETF]     [IP Storage]     [Yosemite News]     [Linux SCTP]     [Linux Newbies]     [Mhonarc]     [Fedora Users]

  Powered by Linux