Re: [Last-Call] [Ohai] Intdir last call review of draft-ietf-ohai-svcb-config-05

[Tommy Pauly <tpauly=40apple.com@xxxxxxxxxxxxxx>]

Thanks for the review, Dave!

Some of the typos were already found and fixed by the Genart review, addressed in this PR: https://github.com/ietf-wg-ohai/draft-ohai-svcb-config/pull/50

The remainder of your comments I’ve addressed in a new PR: https://github.com/ietf-wg-ohai/draft-ohai-svcb-config/pull/51

Best,

Tommy

On Aug 17, 2023, at 2:56 PM, Dave Thaler via Datatracker <noreply@xxxxxxxx> wrote:

Reviewer: Dave Thaler
Review result: Ready with Nits

I am the assigned INTDIR reviewer for this draft. Please treat these comments just
like any other last call comments.

Section 1:

The client learns the URI to use for the gateway using a well-known
URI [WELLKNOWN], "ohttp-gateway",  

"ohttp-gateway" is not a well-known URI, it is a URI suffix.  Please reword.
(Wording is fine in Sections 5, 6, and 8.2, it's only this one sentence that's incorrect.)

This document also defines a way to fetch an gateway's key

s/an gateway/a gateway/

Section 4.1:

supports a Oblivious HTTP could look like this:

s/a Oblivious/an Oblivious/

Section 7:

always checking for a gateway configuration Section 6 on the well-
known gateway location Section 5.  Use of encrypted DNS along with

I can't parse the Section uses in the middle of the sentence.
Maybe they belong in parens?

Section 7.2:

done by limiting the the allowable values of dohpath to a single

s/the the/the/

-Dave




--
Ohai mailing list
Ohai@xxxxxxxx
https://www.ietf.org/mailman/listinfo/ohai

-- 
last-call mailing list
last-call@xxxxxxxx
https://www.ietf.org/mailman/listinfo/last-call