Hi, On Wed, 18 Feb 2009, Keith Cascio wrote: > On Tue, 17 Feb 2009, Johannes Schindelin wrote: > > > > > diff.h | 3 +++ > > > > diff.c | 17 ++++++++++------- > > > > 2 files changed, 13 insertions(+), 7 deletions(-) > > > > If you had not so conveniently clipped what I quoted just before the > > three dots, I could point out that it adds roughly double the number > > of lines as it removes. > > Didn't they say on Mount Sinai? > > "Thou shalt not judge a patch on the diffstat alone." Okay, you asked for it. I tried to be gentle. I see _no_ value in your changes, and the diffstat as a _very_ real downside. If the code would become clearer with your patch, I would not mind. But I find that the result is not more readable than the original. As part of a parse-optification, I would not mind. But before that, no. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
