Re: [PATCH] Use DIFF_XDL_SET/DIFF_OPT_SET instead of raw bit-masking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Feb 2009, Johannes Schindelin wrote:

> > >  diff.h |    3 +++
> > >  diff.c |   17 ++++++++++-------
> > >  2 files changed, 13 insertions(+), 7 deletions(-)
> 
> If you had not so conveniently clipped what I quoted just before the three 
> dots, I could point out that it adds roughly double the number of lines as it 
> removes.

Didn't they say on Mount Sinai?

"Thou shalt not judge a patch on the diffstat alone."
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux