Dscho,
On Tue, 17 Feb 2009, Johannes Schindelin wrote:
> Rationale?
> If you are going to add something on top of that, I can understand that, but
> this patch is not labeled [1/n]. And...
This patch is about consistency. Yes I'd like to add something on top of it.
But these improvements stand well on their own. My work on the
diff.defaultOptions patch highlighted the desirability of handling these bit
manipulations consistently, via macros.
> ... this does not look good to me, without a compelling reason why we want to
> have the patch nevertheless.
Is there something you dislike about the code style? As always I'm happy to
adjust it.
-- Keith
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
