Re: [PATCH] builtin-remote: make reuse of code easier by not die()ing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin a écrit :
> 
> 	Wow, that patch was hard ;-)

This is just what you wanted? I'm a little disappointed. ;-)

> 	BTW this thread shows -- again -- how hard it is to push toward 
> 	libification.  People seem to actively block it.

I don't see how this patch will solve the real problem. You just hide the die()
because get_fetch_map() still can die() and you add dead code. Now, the next
person that will use get_ref_states() will think it always return. Seems worse
to me.

IMHO, if you really want to libify you have to really analyze what should be
done. Split the work in coherent steps, write some specs to explain where you
want to go, how you planed to do it and why?

If you want to go this way, I'm ready to help you to do the hard work.

Olivier.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux