Hi,
On Mon, 9 Jun 2008, Olivier Marin wrote:
> diff --git a/builtin-remote.c b/builtin-remote.c
> index c49f00f..efe74c7 100644
> --- a/builtin-remote.c
> +++ b/builtin-remote.c
> @@ -421,10 +421,10 @@ static void show_list(const char *title, struct path_list *list)
>
> static int show_or_prune(int argc, const char **argv, int prune)
> {
> - int dry_run = 0, result = 0;
> + int no_query = 0, result = 0;
Just for the record (not that I think anybody will care): I do not like
this change.
> @@ -442,21 +442,23 @@ static int show_or_prune(int argc, const char **argv, int prune)
> struct transport *transport;
> const struct ref *ref;
> struct strbuf buf;
> - int i, got_states;
> + int i;
>
> states.remote = remote_get(*argv);
> if (!states.remote)
> return error("No such remote: %s", *argv);
> - transport = transport_get(NULL, states.remote->url_nr > 0 ?
> - states.remote->url[0] : NULL);
> - ref = transport_get_remote_refs(transport);
> - transport_disconnect(transport);
>
> read_branches();
> - got_states = get_ref_states(ref, &states);
> - if (got_states)
> - result = error("Error getting local info for '%s'",
> - states.remote->name);
And I do not like this change either. It proliferates the "we just die()
and do not care about reusing the code where die()ing is not desired"
paradigm.
Sad,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
