On 2024-02-06 at 21:14:04, Tobias Boesch wrote: > 5 Feb 2024 23:29:10 brian m. carlson <sandals@xxxxxxxxxxxxxxxxxxxx>: > > > It's not guaranteed that bash even exists on the system, let alone that > > it's in /bin. For example, this wouldn't work on most of the BSDs. > > This would need to be templated using SHELL_PATH and written in POSIX > > sh (e.g., no `[[`). > > > > I see. I'll try to look into it. If someone knows how to do that let me know. > > >> Icon=/usr/share/git-gui/lib/git-gui.ico > > > > This would also need to be given an appropriate location based on the > > build parameters. > > > > Is it about the build parameters of the build of git(-gui), or about the downstream distros are building? > So git leaves this empty and the packagers full this out? No, this would be built by a Makefile target. You'd provide a template file and adjust it based on something like the `RUNTIME_PREFIX` value, which is used to adjust locations for data. There's examples for scripts, such as git-instaweb, which you can use as an example of how to generate a target file based on the input. This can also be used to work with `SHELL_PATH` as I mentioned above. -- brian m. carlson (he/him or they/them) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
